[#ROR-10] Limit list of refactorings shown in right-click context menu to only those that are enabled for the selection - ASAP

Aptana RadRails

Limit list of refactorings shown in right-click context menu to only those that are enabled for the selection

Created: 01/Nov/07 10:55 AM Updated: 14/Mar/08 06:34 PM

Component/s:

Refactoring

Affects Version/s:

0.9.1

Fix Version/s:

1.1.0

Issue Links:

Depends

This issue is depended on by:

~~ROR-188~~ Right-clicking in Ruby Editor freezes Eclipse solid

Importance:	Average
Studio Install Type:	N/A
Operating System:	Windows Vista
Participants:	Chris Williams

Description

« Hide

All of them show up, but not all are valid and can be run. We need to properly set the enablement based on the user's current selection.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Chris Williams - 14/Nov/07 10:23 AM

A very basic hack should address most of this. For RubyRefactoring.isEnabled() we instantiate the refactoring, grab it's condition checker and ask if it should perform. I'll probably need to go over the refactorings and make sure that we're not getting false positives or negatives.

[ Permlink | « Hide ]

Chris Williams - 17/Dec/07 11:47 AM

Have to re-open due to ~~ROR-188~~.

[ Permlink | « Hide ]

Chris Williams - 17/Dec/07 11:48 AM

Push to 1.0.1 for now.

[ Permlink | « Hide ]

Chris Williams - 14/Mar/08 06:34 PM

Bump enhancements to 1.1.0