[#ROR-942] Problems building RDT against 3.4 Ganymede - ASAP

Aptana RadRails

Problems building RDT against 3.4 Ganymede

Created: 14/Aug/08 07:39 AM Updated: 10/Mar/09 12:10 PM

Return to search

Component/s:

None

Affects Version/s:

1.0.3

Fix Version/s:

1.2.0

File Attachments:

eclipse-3.4.patch (2 kb)
2.

eclipse-3.4.patch (3 kb)

Impact on Workflow:	Critical
Studio Install Type:	Eclipse Plugin
Participants:	Chris Williams and James Le Cuirot

Description

« Hide

I'm afraid 1.0.4 (or the latest from the 1.0 branch anyway) does not just work in 3.4 as you have stated. It may appear to work at first when build against 3.2 but if many errors occur when building against 3.4 then you're surely going to encounter problems. I had already patched RDT to work with 3.3. The debug message part of the attached patch was added for 3.4. More still needs to be done though. org.eclipse.search.internal.ui.text.ResourceTransferDragAdapter has been removed and apparently you should use NavigatorDragAdapter instead. That doesn't sound like a quick fix so I'm passing this on to you.

All

Comments

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

James Le Cuirot - 14/Aug/08 09:11 AM

Hmm looks as though this has all been fixed in trunk so sorry for creating this. I would have noticed sooner but I had to guess the URL for trunk since it's not documented on the site.

[ Permlink | « Hide ]

James Le Cuirot - 14/Aug/08 10:07 AM

Funny, I tried to build trunk against 3.4 and even though I still had to apply the fixes for 3.3, all the other problems I encountered with 1.0.4 were gone. Here's a patch for that. It doesn't include the Lanuch/Launch typo fix.

[ Permlink | « Hide ]

Chris Williams - 15/Aug/08 01:11 PM

Thanks for the patches. 1.0.3 should work fine when you're running our pre-built binaries inside Eclipse 3.4, but yes trying to build the source against 3.3 or 3.4 it will be broken. As you've said I've worked on that in trunk, and that should be OK on 3.2, 3.3 and 3.4 to build (as near as I can tell).

I'll take a look at these patches today...

[ Permlink | « Hide ]

Chris Williams - 20/Aug/08 10:30 AM

I have to push this to 1.2 since that should be the release that we're finally targeting 3.4 as the base platform. This patch is still valid, but a couple changes in here would break our ability to build against 3.2 which is what we use right now.

[ Permlink | « Hide ]

Chris Williams - 16/Jan/09 10:30 AM

We build fine against 3.4 now in trunk. RadRails 1.2 will be generated from trunk (and so will RDT 1.2). These are tied to Studio 1.3's release which is due in a couple weeks or so, where we move to using 3.4 as our target and base.

[ Permlink | « Hide ]

Chris Williams - 10/Mar/09 12:01 PM

Only tie things resolved in 1.1.2 and 1.2.0 to 1.1.2 as fixed version (since it's assumed that 1.2.0 as a later release will contain all the previous release's bugfixes).